fixes 3177: a 'G' suffix is automatically appended to libvirt volume capacity value if none was specified #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| def validate_volume_capacity(vol) | ||
| if vol.capacity.to_s.empty? or /^\d+G?$/.match(vol.capacity.to_s).nil? | ||
| raise _("Please specify volume size. You may optionally use suffix 'G' to specify volume size in Gigabytes.") |
There was a problem hiding this comment.
Foreman::Exception should be used here I think.
There was a problem hiding this comment.
A RuntimeError is used in a couple of other spots here -- should those be changed too?
|
Could you file a redmine ticket about this issue please? We don't use BZs. |
|
@domcleal: ping? |
| @@ -107,7 +107,7 @@ def create_vm args = { } | |||
|
|
|||
| def console uuid | |||
| vm = find_vm_by_uuid(uuid) | |||
| raise "VM is not running!" unless vm.ready? | |||
| raise Foreman::Exception.new(_("VM is not running!")) unless vm.ready? | |||
There was a problem hiding this comment.
These need to be N_() when using Foreman::Exception, as it takes the English string to compute the message, then runs it through _() when rendered.
… capacity value if none was specified
|
@domcleal: ping? |
|
Thanks @witlessbird! Merged as dab82c9 for Foreman 1.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the UI to volume capacity could be improved. libvirt internally stores volume sizes in bytes, but allows to specify the size in a variety of units. We could switch to follow the same convention.
It's a bit confusing atm, as libvirt expects a suffix to be present, but we only support one -- "G".