fixes #3133 - fix security group filtering when no groups need filtering #921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"[compact!] returns nil if no changes were made, otherwise returns the array"
http://www.ruby-doc.org/core-2.0.0/Array.html#method-i-compact-21
Hence if there are no VPC groups (vpc_id are all nil), the security_groups array is unfiltered, and the method returned nil rather than all the non-VPC security groups.