Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fog-google 1.14+ which is compatible with Ruby 3.0 #9226

Merged
merged 1 commit into from May 23, 2022

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented May 19, 2022

No description provided.

@evgeni evgeni requested a review from a team as a code owner May 19, 2022 07:45
@evgeni evgeni changed the title use fog-google 1.13+ which is compatible with Ruby 3.0 use fog-google 1.14+ which is compatible with Ruby 3.0 May 19, 2022
fog-google 1.13 started announcing 3.0 compatibility in the gem spec,
but 1.14 contains bug fixes to actually make it work
@evgeni
Copy link
Member Author

evgeni commented May 19, 2022

packaging update in theforeman/foreman-packaging#7942

Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the packaging PR is green, for me the changes look good to coordinate merge on. @evgeni You may want to stage up a draft PR to update the Foreman RPM dependencies as well.

@evgeni evgeni merged commit b797b97 into theforeman:develop May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants