[REFACTOR] fixes #3205 Extracts report importing logic #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, I like that it aligns with the facts importer. Could you also move the import tests from the report unit test into one named after this new service class (a la test/unit/facts_importer_test.rb)? |
|
@ohadlevy a test failed: Failed assertion, no message given. (test_0001_it should true on error? if there were errors) /var/lib/workspace/workspace/test_develop_pull_request/database/mysql/puppet/3.0/ruby/1.8.7/test/unit/report_test.rb:11 |
|
@domcleal fixed and rebased |
|
I realize we now have multiple methods in test that parse json fixtures, should probably fix it in another commit |
|
@ohadlevy not fixed :) |
|
rebased again, thanks @domcleal |
| when Hash | ||
| ReportStatusCalculator.new(:counters => st).calculate | ||
| else | ||
| raise Foreman::Exception(_('Unsupported report status format')) |
There was a problem hiding this comment.
This should be N_(), as we don't want to translate immediately (in order to calculate a static error ID)
|
@domcleal fixed :) |
|
[test] |
| end | ||
|
|
||
| def initialize(raw) | ||
| raise ::Foreman::Exception.new(_('Invalid report')) unless raw.is_a?(Hash) |
|
Could you rebase please? :) |
|
rebased |
This patch extracts all report importing logic into seperate importer and status classes. long term this could allow: 1. aliases methods for async operations 2. different types of reports imports (based on reporting type).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extracts all report importing logic into seperate importer class.
long term this could allow: