New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 7 & Ruby 3.1 #9328

Draft

ekohl wants to merge 9 commits into theforeman:develop from ekohl:rails-7-ruby-3.1

Member

ekohl commented Jul 30, 2022 •

edited

Loading

This is what I had to do to get Rails 7 to at least migrate and start up on Ruby 3.1. Then I noticed #9287 does a lot of the same work.

There's also a bunch of gem updates prepended to this which can be submitted separately. Split off PRs:

Member

theforeman-bot commented Jul 30, 2022

Issues: #32685

theforeman-bot added Waiting on contributor Needs testing Not yet reviewed GraphQL labels

ekohl mentioned this pull request

Closed

ekohl force-pushed the rails-7-ruby-3.1 branch from a9e3ffc to b832355 Compare

July 30, 2022 19:12

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels

ekohl force-pushed the rails-7-ruby-3.1 branch from b832355 to c9902ae Compare

July 30, 2022 21:51

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels

ekohl force-pushed the rails-7-ruby-3.1 branch from c9902ae to d5f05a4 Compare

August 2, 2022 11:26

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels

Member Author

ekohl commented Aug 2, 2022

Rebased since some preparation work was merged. No real change compared to the previous version.

My plan is to submit the gem updates after branching, which would give us a much more solid base to work on. Then we can also look at the Zeitwerk changes in more detail.

theforeman-bot removed Needs testing Not yet reviewed labels

Member

theforeman-bot commented Aug 25, 2022

@ekohl, this pull request is currently not mergeable. Please rebase against the develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream develop

This message was auto-generated by Foreman's prprocessor

4 similar comments

Member

theforeman-bot commented Aug 25, 2022

@ekohl, this pull request is currently not mergeable. Please rebase against the develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream develop

This message was auto-generated by Foreman's prprocessor

Member

theforeman-bot commented Aug 25, 2022

@ekohl, this pull request is currently not mergeable. Please rebase against the develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream develop

This message was auto-generated by Foreman's prprocessor

Member

theforeman-bot commented Aug 25, 2022

@ekohl, this pull request is currently not mergeable. Please rebase against the develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream develop

This message was auto-generated by Foreman's prprocessor

Member

theforeman-bot commented Aug 31, 2022

@ekohl, this pull request is currently not mergeable. Please rebase against the develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream develop

This message was auto-generated by Foreman's prprocessor

ekohl force-pushed the rails-7-ruby-3.1 branch from d5f05a4 to 7175bd6 Compare

September 28, 2022 09:50

theforeman-bot added Needs re-review Waiting on contributor and removed Waiting on contributor labels

Member Author

ekohl commented Sep 28, 2022

This is still not ready for consumption, but since a lot of preparation work has been merged I've rebased this to make the PR a bit easier to grasp.

Member Author

ekohl commented Sep 28, 2022

Katello needs to update:

[2022-09-28T09:51:13.727Z] Bundler could not find compatible versions for gem "railties":
[2022-09-28T09:51:13.727Z]   In Gemfile:
[2022-09-28T09:51:13.727Z]     katello was resolved to 4.7.0.pre.master, which depends on
[2022-09-28T09:51:13.727Z]       angular-rails-templates (~> 1.1.0) was resolved to 1.1.0, which depends on
[2022-09-28T09:51:13.727Z]         railties (< 7, >= 4.2)
[2022-09-28T09:51:13.727Z] 
[2022-09-28T09:51:13.727Z]     rails (~> 7.0.3) was resolved to 7.0.3, which depends on
[2022-09-28T09:51:13.727Z]       railties (= 7.0.3)

Version 1.2 of that gem does support Rails 7.

Member

theforeman-bot commented Dec 29, 2022

Thank you for your contribution, @ekohl! This PR has been inactive for 3 months, closing for now.
Feel free to reopen when you return to it. This is an automated process.

github-actions bot commented Nov 6, 2023

Thank you for your contribution! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.

github-actions bot added the Inactive label

github-actions bot closed this

ekohl reopened this

ekohl force-pushed the rails-7-ruby-3.1 branch from d6e5273 to 2cc8679 Compare

November 16, 2023 18:11

Member Author

ekohl commented Nov 16, 2023

Rebased to drop now irrelevant. No real changes compared to the previous one.

github-actions bot removed Inactive Stale labels

github-actions bot added the Stale label

github-actions bot commented Feb 24, 2024

Thank you for your contribution! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.

github-actions bot added the Inactive label

github-actions bot closed this

ekohl reopened this

ekohl force-pushed the rails-7-ruby-3.1 branch from 2cc8679 to 4e52974 Compare

February 29, 2024 10:33

github-actions bot removed Inactive Stale labels

Member Author

ekohl commented Mar 4, 2024

Needs a rebase now that #9770 is merged, but I've opened #10076 which is a part of the Zeitwerk work commit that's included here. To avoid continuously rebasing, I'm waiting for that to be merged.

ekohl added 4 commits

April 25, 2024 13:43


          Fixes #33895 - Set up Zeitwerk inflector

36b857e

Zeitwerk uses constant to snake case to resolve the paths. If we want to
change some constants to be Uppercase, we need to use the inflector.

WIP

6c8d6e2


          Fixes #35463 - Allow newer rdoc on Ruby 3.1

57336e4

Ruby 3.1 ships rdoc 6.1 by default.


          Fixes #35431 - Update spring to 4.x

e57f49e

Currently version 2 is used, but version 3 brings Ruby 3 support.
Version 4 is the latest. The only backwards incompatible changes they
mention[1] are requiring Ruby >= 2.7 and Rails >= 6.0, which is not a
problem for Foreman.

Version 3 enforces that cache_classes is turned off, in particular for
test environments.

[1]: https://github.com/rails/spring/blob/main/CHANGELOG.md

ekohl force-pushed the rails-7-ruby-3.1 branch from 4e52974 to 07690b5 Compare

April 25, 2024 11:46

ekohl added 4 commits

April 25, 2024 14:06


          Zeitwerk work

a67f626


          Explicitly state belongs_to are optional

834b6ca

While there is a setting which we change, this allows running with Rails
5+ default settings.


          Switch to Rails 7

cae9879

This drops the redirect_back_or_to method that Rails now natively
implements.

It also configures Foreman to raise errors on open redirects, similar to
what was implemented in 2517ba4. Rails
7.0 introduced this as a config option, but only enables it if you load
the 7.0 defaults while after this change it still loads the 6.1
defaults.


          Run tests with the number of processors

4bbdc55

ekohl force-pushed the rails-7-ruby-3.1 branch from 07690b5 to 4bbdc55 Compare

April 25, 2024 12:15


          Fixes #31977 - Turn on eager loading in test env

16033d7

Member Author

ekohl commented Apr 26, 2024

Tests fail at least on 2 issues:

It can't create a temporary facet to test out facets
uninitialized constant Fog::Ovirt::Compute::OperatingSystem

I wonder if the latter is because lib/fog/ovirt/models/compute/operating_system.rb contains Fog::Ovirt::Compute::OperatingSystem, which doesn't follow the regular convention.

Or this bit isn't working anymore:

foreman/config/application.rb

Lines 68 to 70 in a57aac0

    
           # CRs in fog core with extra dependencies will have those deps loaded, so then 
        
           # load the corresponding bit of fog 
        
           require 'fog/ovirt' if defined?(::OVIRT)

Though I really question why it would be needed, since we already attempt to load the ovirt group:

foreman/config/application.rb

Lines 59 to 61 in a57aac0

    
           optional_bundler_groups = %w[assets ec2 fog libvirt openstack ovirt vmware redis] 
        
           optional_bundler_groups.each do |group| 
        
             Bundler.require(group)

Perhaps it raises an exception that's quietly swallowed?

github-actions bot added the Stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment