-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #35397 - Preseed Autoinstall incorporate host_params #9363
Fixes #35397 - Preseed Autoinstall incorporate host_params #9363
Conversation
Issues: #35397 |
0928273
to
aef9688
Compare
Integration test looks unrelated IMHO. |
d830cb4
to
4ccfafb
Compare
57a726b
to
90dae99
Compare
@sbernhard do you have feedback maybe? |
Hey @MariaAga! Maybe you are busy at the moment - just wanted to ask to assign someone to this PR please :) evgeni reviewed PRs regarding Ubuntu Autoinstall before. |
app/views/unattended/provisioning_templates/user_data/preseed_autoinstall_cloud_init.erb
Outdated
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/user_data/preseed_autoinstall_cloud_init.erb
Outdated
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/user_data/preseed_autoinstall_cloud_init.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review @evgeni!
app/views/unattended/provisioning_templates/user_data/preseed_autoinstall_cloud_init.erb
Outdated
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/user_data/preseed_autoinstall_cloud_init.erb
Outdated
Show resolved
Hide resolved
17e1a2d
to
39bb167
Compare
39bb167
to
6f11efd
Compare
6f11efd
to
d095c4c
Compare
@evgeni are there any more questions regarding the architecture? I just rebased to the latest master. |
d095c4c
to
397c91b
Compare
I'm still trying to wrap my head why you set |
It relates to this post about disabling the automatic update: Stackoverflow It's the configuration which worked with the official Ubuntu image as an installation media. |
Okay, and then the user ends up with a system that has the updates/security repos disabled, and you need a config management tool to re-enable them? |
And maybe more to the "why": https://projects.theforeman.org/issues/35397 speaks about missing parameters, like Not saying this change as such is wrong, I just don't understand the motivation behind it (the mirror part) |
The motivation behind this is actually related to a katello-based environment. When deploying a host with
In general, it is useful to have this variable especially in case of a smart proxy setup. Depending on the configuration, the local repo might be on the foreman itself, but in other cases the smart proxy could contain a copy of that repo. I thought that a host parameter would solve this issue quite elegantly, since we can now define the parameter per host group. Thanks for your feedback on this! Highly appreciated 🙌 |
Langsam wird ein Schuh draus ;-) So the real problem is that the auto-updates repo and the later configured repo are different repos, and thus can be out of sync and we end up doing certain operations twice, prolonging the update. That's certainly something we should improve!
A "normal" smart proxy will never have repos, it has no such capability. A Katello one will, but then I would actually expect Katello to be able to tell us the repo url with the right proxy used, so we don't have to guess and/or set it manually as a parameter? And yes, I think we should split this one into one PR for keyboard/locale, that gets an instant ack and can be merged, and then we can discuss the details of the repo part. |
* Param 'keyboard' to set default layout * Param 'lang' to set default locale * Adapt template snapshot accordingly Co-authored-by: Bastian Schmidt <schmidt@atix.de> Co-authored-by: Evgeni Golov <evgeni@golov.de>
397c91b
to
01f051d
Compare
Several host params exist to make the host creation more configurable ('keyboard' to set the layout, 'lang' to set the locale). The Ubuntu Autoinstall cloud-init template does not take any of these parameters into account.
This PR incorporates the following: