New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #35497 - New host UI - Link to host group #9414
Conversation
stejskalleos
commented
Sep 7, 2022
•
edited
edited
Issues: #35497 |
webpack/assets/javascripts/react_app/components/HostDetails/DetailsCard/index.js
Outdated
Show resolved
Hide resolved
I haven't tested but would like to ask, what does it do when a user does not have a permission to view that host group? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! can you please use https://www.patternfly.org/v4/components/button in its inline link state?
Also from what I see in the design there should be an edit icon, and then the url on the name itself should be linked to the host search.
https://marvelapp.com/prototype/995cc27/screen/77850645
Please use pfs react icons, here it should be PencilAltIcon
We use pf components for consistency in looks and qe testing
022d365
to
1cfd854
Compare
After user clicks on the edit icon he's redirected to the host group edit page with permission denied error @MariaAga I updated PR however I failed with the styling of components, https://marvelapp.com/prototype/995cc27/screen/77850645 shows design but I wasn't able to do it with PF4, I couldn't even make the icon in different color, docs for it shows some variables but I have no idea how to implement it. Do we have any source code sample somewhere? |
1cfd854
to
576677c
Compare
Icon & empty state fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just noticed now that in the design the pencil is aligned to the right, other than that everything is working as it should
576677c
to
37392b5
Compare
fixed |
webpack/assets/javascripts/react_app/components/HostDetails/DetailsCard/index.js
Outdated
Show resolved
Hide resolved
37392b5
to
3397fdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!