Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35497 - New host UI - Link to host group #9414

Merged
merged 1 commit into from Sep 29, 2022

Conversation

stejskalleos
Copy link
Contributor

@stejskalleos stejskalleos commented Sep 7, 2022

Screenshot from 2022-09-07 14-26-09

@theforeman-bot
Copy link
Member

Issues: #35497

@ares
Copy link
Member

ares commented Sep 8, 2022

I haven't tested but would like to ask, what does it do when a user does not have a permission to view that host group?

@MariaAga MariaAga self-assigned this Sep 9, 2022
Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! can you please use https://www.patternfly.org/v4/components/button in its inline link state?
Also from what I see in the design there should be an edit icon, and then the url on the name itself should be linked to the host search.
https://marvelapp.com/prototype/995cc27/screen/77850645
Please use pfs react icons, here it should be PencilAltIcon
We use pf components for consistency in looks and qe testing

@stejskalleos
Copy link
Contributor Author

I haven't tested but would like to ask, what does it do when a user does not have a permission to view that host group?

After user clicks on the edit icon he's redirected to the host group edit page with permission denied error

@MariaAga I updated PR however I failed with the styling of components, https://marvelapp.com/prototype/995cc27/screen/77850645 shows design but I wasn't able to do it with PF4, I couldn't even make the icon in different color, docs for it shows some variables but I have no idea how to implement it. Do we have any source code sample somewhere?

@MariaAga
Copy link
Member

For the edit button, the variant should be variant="plain" instead of a link to fix the color.
Also the button should not be shown if there is no host group
Screenshot from 2022-09-14 09-57-29

@stejskalleos
Copy link
Contributor Author

Icon & empty state fixed

Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed now that in the design the pencil is aligned to the right, other than that everything is working as it should

@stejskalleos
Copy link
Contributor Author

Sorry, just noticed now that in the design the pencil is aligned to the right, other than that everything is working as it should

fixed

Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@MariaAga MariaAga merged commit b4fff06 into theforeman:develop Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants