Fixes #35780 - Automatically deploy storybook #9517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than building it in the gh-pages branch you can now upload pages directly. This action makes sure the storybook is up to date and we can delete the gh-pages branch.
|
Issues: #35780 |
Removal is proposed in https://community.theforeman.org/t/rfc-removing-storybook/33644 but we can consider publishing a rendered version of the developer docs instead. |
|
We dropped the storybook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than building it in the gh-pages branch you can now upload pages directly. This action makes sure the storybook is up to date and we can delete the gh-pages branch.
I just ran this on my own fork and it looks like it can't even build: https://github.com/ekohl/foreman/actions/runs/3531042266/jobs/5923747028.
Today we had the discussion about https://theforeman.github.io/foreman/ which is very old. Looking at this we either need to make it work again or delete the old content.