Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35816 - ISE when passing org_id as an array #9532

Merged
merged 1 commit into from Dec 3, 2022

Conversation

sjha4
Copy link
Contributor

@sjha4 sjha4 commented Dec 2, 2022

Steps to reproduce:

curl -u admin: -k -H "Content-Type:application/json" -H "Accept:application/json" -X POST https://$FQDN/katello/api/v2/content_views -d '{"name": "test1", "organization_id": [1], "api_version": "v2", "content_view": {"name": "test1", "organization_id": [1]}}'

Note the organization_id passed as an array.

@theforeman-bot
Copy link
Member

Issues: #35816

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder where it is valid to send an array for the resource ID. I doubt we have input validation to reject it somewhere.

Still, it's certainly better to not crash.

@ekohl ekohl merged commit 3369ff1 into theforeman:develop Dec 3, 2022
@MariaAga MariaAga added the Needs cherrypick This should be cherrypicked to the stable branches or branches label Dec 6, 2022
@ekohl
Copy link
Member

ekohl commented Dec 13, 2022

Cherry picked to 3.5-stable as adda07a

@sjha4 sjha4 deleted the issue35816 branch December 15, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs cherrypick This should be cherrypicked to the stable branches or branches
Projects
None yet
4 participants