Fixes #35853 - compute_resources_vms_controller_test #9551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: 1) @vm.volumes with array of nils instead of volumes ComputeResourcesVmsControllerTest#test_0001_should show vm: ActionView::Template::Error: undefined method `allocation' for nil:NilClass 2) Missing flags => 0 in default options for destroy method, see fog-libvirt PR [0] ComputeResourcesVmsControllerTest#test_0001_should destroy vm: NoMethodError: undefined method `zero?' for nil:NilClass [0] https://github.com/fog/fog-libvirt/pull/102/files
|
Issues: #35853 |
ekohl
reviewed
Dec 12, 2022
| @@ -54,7 +54,7 @@ def find_vm_by_uuid(uuid) | |||
|
|
|||
| # we default to destroy the VM's storage as well. | |||
| def destroy_vm(uuid, args = { }) | |||
| find_vm_by_uuid(uuid).destroy({ :destroy_volumes => true }.merge(args)) | |||
| find_vm_by_uuid(uuid).destroy({ destroy_volumes: true, flags: 0 }.merge(args)) | |||
There was a problem hiding this comment.
I released a compatible 0.11.0 today so this shouldn't be needed anymore.
There was a problem hiding this comment.
And I should have linked fog/fog-libvirt#125 as well.
| @@ -40,7 +40,7 @@ | |||
| <td><%= "#{nic.bridge} - #{nic.mac} (#{nic.model})" %></td> | |||
| </tr> | |||
| <% end %> | |||
| <% @vm.volumes.each do |vol| %> | |||
| <% @vm.volumes.compact.each do |vol| %> | |||
There was a problem hiding this comment.
I wonder why it's returning nil in that list. Feels like an upstream regression as well. Could you have a look if we can solve it in fog-libvirt?
There was a problem hiding this comment.
yop, I'll take a look ...
|
Closing, fixed in fog-libvirt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
[0] https://github.com/fog/fog-libvirt/pull/102/files
How to test: