New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2572 basic FreeBSD support #956
Conversation
app/assets/images/FreeBSD.png app/helpers/operatingsystems_helper.rb
I guess we'll need some templates to go with this. Would that be an rc.local and then pc-sysinstall, or something else? |
the templates i.e. app/views/unattended/memdisk.rhtml are part of the inital PR (although memdisk might not be the best name) |
@@ -1,8 +1,12 @@ | |||
#kind: snippet | |||
#name: puppet.conf | |||
[main] | |||
<% if @host.operatingsystem.name == "FreeBSD" -%>vardir = /var/puppet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you added the -%> I think you can do it in two seperate lines...
besides that, @domcleal any concern about puppet.conf changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope
@endyman which PR do you refer to? its better to have it all as one PR? |
#673 was the initial PR including the templates |
Yes, that is the original PR #673. But I disagree to many points in the templates there that makes them custom instead of universal:
We should focus on a combination of some kind of standard mfsBSD image calling a standard script, and the contents of this script should be provided by Foreman. The user is then able to customize almost everything. |
Template are not generic they are meant to be adapted and offer basic support - the debian, centos and rhel templates most likely are never going to be used that way - people will use them as a blueprint to get started and will modify or clone them to fit their need in terms of network config, disk layouts, hardware and packages. So the basic question is - do we want to have templates for FreeBSD (we cannot write templates to cover everything) or do we want to document how a user must setup templates in order to install i.e. pc-sysinstall. In regards to your last point +1
You could ship the code loading with mfsBSD so that the user can turn on / off the provisioning - or just leave it up to the user to use the rc.local hook and write a custom script. The script could cat some data to tmp later used for any installer and execute the installer so we have maximum flexibility right ? |
I was thinking of a "Foreman"-edition of mfsBSD with the necessary support (a custom rc.local) The only other possibility would be chain-booting via pxeboot and using a customized loader.conf - I have no idea how can we easily customize this for many different machines. |
Okay - anyway: we had a discussion to implemet FreeBSD in two steps - first step is basic support. I think we have achived this and I'm perfectly fine with Martins PR. We can improve support later on by implementing custom options for BSD. @ohadlevy what do you think? |
This is stripped code from endyman with some changes to provide basic support for FreeBSD