Refs #35578 - Fix netplan interface template logic #9560
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix introduced an
end
at the wrong place which results in bad configuration for systems with dhcp enabled.In the current version, the
nameserver
field is printed independent of a static or dhcp environment. AFAIK and in the prior behavior of this snippet, it should only be added in a static setup.Current version:
New version:
This PR adds indentation to the erb clauses which might explain the cause of this issue in the first place.
Fixes: e74661e
@anthonysomerset and @ekohl maybe you can verify this patch since the issue was introduced in #9515.