Fixes #36082 - Ensure character & is escaped on ks URL #9620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36082 |
wbclark
reviewed
Feb 14, 2023
| @@ -39,19 +39,19 @@ description: | | |||
| # both current and legacy syntax provided | |||
| if (is_fedora && os_major >= 33) || (rhel_compatible && os_major >= 9) | |||
| if subnet4 && !subnet4.dhcp_boot_mode? | |||
| options.push("inst.ks=#{foreman_url('provision', static: '1')}") | |||
| options.push("inst.ks=#{foreman_url('provision', static: '1').gsub('&','\\\\&')}") | |||
There was a problem hiding this comment.
Suggested change
| options.push("inst.ks=#{foreman_url('provision', static: '1').gsub('&','\\\\&')}") | |
| options.push("inst.ks=" + format("'%s'", foreman_url('provision', static: '1'))) |
one thought: quoting the URL for grub should also work, could prevent similar future issues from occurring for other characters than &, and might be a bit easier to read for the next engineer vs. trying to figure out which escapes are in which layer... what do you think?
either way, it's probably a good idea to give the same treatment as well to the lines which set inst.repo and inst.stage2
There was a problem hiding this comment.
My provisioning tests failed when using "PXELinux BIOS" as PXE Loader and a quoted URL for ks.
That's why I went for this approach, which worked for both "PXELinux BIOS" and "Grub2 UEFI".
|
I'm closing the PR, it's duplicate to #9477, let's continue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes will ensure that character & is properly escaped on any ks URL used for provisioning.