Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36129 - Force ellipsis on all columns #9629

Merged
merged 1 commit into from Mar 7, 2023

Conversation

ofedoren
Copy link
Member

Before:
ScreenShot-1676903493947
After:
ScreenShot-1676901471629

The solution is still not perfect, but that's just the start. A better soultion will be to make the table horizontally scrollable, but I don't think it's adequately implementable due to old Bootstrap used in hosts table. We would need to rewrite the table into PF4.

The issue can be divided into few patches:

  • Unify view via 'ellipsis' class (this PR)
  • Make table scrollable (needs further changes)
  • Make 'hostname' column sticky (better UX since this is the most valuable info)

P.S. Affects only core columns, if accepted I'll open patches to plugins.

@theforeman-bot
Copy link
Member

Issues: #36129

@ares
Copy link
Member

ares commented Feb 21, 2023

if we had the dedicated plugins DSL for adding columns as you originally proposed, we wouldn't have to add this class manually everywhere

@ofedoren
Copy link
Member Author

if we had the dedicated plugins DSL for adding columns as you originally proposed, we wouldn't have to add this class manually everywhere

Hmm... Indeed, that approach had common_class built in DSL, so the changes would apply mainly here, but still we would need to make sure we use the defaults everywhere. Or force it being used, but then still it would be better to remove then explicit usages just to clean things up.

We would still need to rewrite the table into React, so I don't think it will matter then.

@ares
Copy link
Member

ares commented Feb 23, 2023

needs rebase now (btw just to be clear, I won't have time to review/merge this properly)

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having to explicitly put the class everywhere is a bit of a pain, but it does the trick. Let's carry it as a workaround for now until we get a PF4+react based table

@adamruzicka adamruzicka merged commit e21b551 into theforeman:develop Mar 7, 2023
@adamruzicka
Copy link
Contributor

Thank you @ofedoren !

@adamruzicka adamruzicka added the Needs cherrypick This should be cherrypicked to the stable branches or branches label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs cherrypick This should be cherrypicked to the stable branches or branches
Projects
None yet
5 participants