Fixes #36189 - Add AlmaLinux UEFI provisioning support #9648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Issues: #36189 |
In pxegrub2_chainload.erb various paths are tried, but the /EFI/almalinux/grubx64.efi path is missing. This causes the server to refuse to boot. To make it easier to use the AlmaLinux installation medium is added.
omenos
force-pushed
the
36189-almalinux-uefi-chainload
branch
from
9e7f002
to
dc9c885
Compare
Conan-Kudo
approved these changes
Mar 10, 2023
|
ok to test |
ekohl
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Looks good to me and I kicked of CI. @stejskalleos mind having a look?
|
Code changes LGTM too, but I am still struggling with the setup of the environment for UEFI & HTTP provisioning. When I'll have it I will test it and merge the PR. |
stejskalleos
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
🍏 LGTM
I haven't tested it because still couldn't manage to find time to configure my setup,
however it looks sensible and does same as #9295, so let's get this in.
|
Thanks @omenos and everyone! |
|
@ekohl @stejskalleos @Conan-Kudo Thanks for the reviews and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit-for-bit copy of #9295, modified for AlmaLinux.
In pxegrub2_chainload.erb various paths are tried, but the /EFI/almalinux/grubx64.efi path is missing. This causes the server to refuse to boot.
To make it easier to use the AlmaLinux installation medium is added.