fixes #3377 - add altlinux support #966

sergelogvinov · 2013-10-20T08:27:32Z

Ticket http://projects.theforeman.org/issues/3377

Add altlinux os support.

ohadlevy · 2013-10-20T08:45:41Z

[test]

ohadlevy · 2013-10-20T08:47:02Z

@GregSutcliffe can you review please?

GregSutcliffe · 2013-10-21T11:07:21Z

app/models/operatingsystems/altlinux.rb

@@ -0,0 +1,39 @@
+class Altlinux < Operatingsystem
+
+  #PXEFILES = {:kernel => "vmlinuz", :initrd => "full.cz", :stagename => "altinst"}


Nitpick: leftover comment?

GregSutcliffe · 2013-10-21T11:11:01Z

@sergelogvinov a few small questions, but looks ok overall. I feel it might need some tests though - @domcleal thoughts?

domcleal · 2013-10-21T11:20:07Z

app/views/unattended/alterator.erb

@@ -0,0 +1,23 @@
+<% if @metadata.to_s == 'vm-profile' -%>


I don't recognise @metadata, is that one of ours?

Ignore me, I see you added it :)

ohadlevy · 2013-10-27T09:24:04Z

@sergelogvinov ping ?

sergelogvinov · 2013-10-27T10:53:11Z

#966 (comment)

ohadlevy · 2013-10-27T11:45:37Z

@sergelogvinov ah, somehow github hides that thread...

so it actually expects a tar with a directory structure?!! any alternatives?

sergelogvinov · 2013-10-28T05:27:56Z

group in pkg-groups.tar use in autoinstall.scm (section /pkg-install).

alternatives..

set proxy on apache/nginx/lighttpd before foreman (not universal method, pkg-groups.tar always one version)
refactoring alterator-pxe installer - i am not maintainer altlinux
use proxy on ruby, media_get_content()

I use media_get_content(), because this very simple method.

what do you think? ideas?

sergelogvinov · 2013-11-01T16:06:20Z

Maybe create tar file from memory use code like https://gist.github.com/sinisterchipmunk/1335041 (see tar function).
Body get from snippet, as result we have tar file with one file inside (section /pkg-install in autoinstall.scm anymore not use).

But how to implement it in Foreman style.

ohadlevy · 2013-12-25T09:54:34Z

@sergelogvinov sorry for the long pause in review, hopefully we can get it... questions:

I believe i still didnt get the whole picture, what is the relationship to a proxy?
if we must provide it as a tar, i assume the tar is static, and as such, we could put it under public, then you could simply File.read(Rails.root + /public...) instead of a second http call.

TBH I don't understand whats the idea behind the tar, can you refer me to any docs?

dLobatog · 2014-04-18T19:17:37Z

@sergelogvinov ping, can you rebase?

sergelogvinov · 2014-04-27T09:10:37Z

Sorry for the delay.
Give me two days please.

dLobatog · 2014-06-18T09:27:01Z

app/models/operatingsystem.rb

@@ -52,6 +52,7 @@ class Operatingsystem < ActiveRecord::Base
               'Redhat'    => %r{RedHat|Centos|Fedora|Scientific|SLC|OracleLinux}i,
               'Suse'      => %r{OpenSuSE|SLES|SLED}i,
               'Windows'   => %r{Windows}i,
+               'Altlinux' => %r{Altlinux}i,


Please align the => sign

domcleal · 2014-06-23T10:54:49Z

A lot's changed since this was opened, I hope you're serious about including it if asking for updates/rebases. Please note that templates have to go via community-templates now, don't merge directly into the Foreman tree.

…x_support

sergelogvinov · 2014-06-24T17:06:11Z

Pull request altlinux templates theforeman/community-templates#86

domcleal · 2014-07-10T07:33:27Z

community-templates PR was merged, thanks [test]. back to @elobato

lzap · 2014-07-10T10:21:58Z

In regard to the logo, I am unable to find license under the AltLinux logo author is providing it.

http://www.altlinux.org/%D0%9B%D0%BE%D0%B3%D0%BE%D1%82%D0%B8%D0%BF%D1%8B

To me it looks like we need to either contact them or find the license, or remove the logo and replace it with something from our dummy icons repo:

https://github.com/lzap/foreman-dummy-icons/blob/master/21x21-goldenrod/a.png

dLobatog · 2014-07-10T10:34:26Z

@sergelogvinov thank you! It looks nearly ready to merge now, there is one test that is broken after the latest update

https://github.com/theforeman/foreman/blob/develop/test/unit/operatingsystem_test.rb#L178 , those arrays need to include 'Altlinux' too.

Also let's remove the logo for the moment as it's unclear whether or not it can be used here, when we figure out if it can be used we'll put it and we can use one of @lzap 's logos from this project for the moment, https://github.com/lzap/foreman-dummy-icons , black is my preference.

lzap · 2014-07-10T11:02:55Z

I've already added the icon in this PR:

https://github.com/theforeman/foreman/pull/1558/files

Please remove it from here. Discuss there.

LZ

Later,
Lukas "lzap" Zapletal

dLobatog · 2014-07-17T14:42:50Z

[test] , thanks for pushing new changes

dLobatog · 2014-07-17T15:44:02Z

test/unit/operatingsystem_test.rb

@@ -176,8 +176,8 @@ class OperatingsystemTest < ActiveSupport::TestCase

    test "families_as_collection contains correct names and values" do
      families = Operatingsystem.families_as_collection
-      assert_equal ["AIX", "Arch Linux", "Debian", "FreeBSD", "Gentoo", "Junos", "Red Hat", "SUSE", "Solaris", "Windows"], families.map(&:name).sort
-      assert_equal ["AIX", "Archlinux", "Debian", "Freebsd", "Gentoo", "Junos", "Redhat", "Solaris", "Suse", "Windows"], families.map(&:value).sort
+      assert_equal ["AIX", "ALTLinux", "Arch Linux", "Debian", "FreeBSD", "Gentoo", "Junos", "Red Hat", "SUSE", "Solaris", "Windows"], families.map(&:name).sort


As you put 'Altlinux' there , it should be the same here. Note only the first letter is upper case.

It's the only test failing, sorry for going back and forth on this. Mention me in a comment so I notice via email that you updated this so I can take a look at it quickly.
http://ci.theforeman.org/job/test_develop_pr_core/1599/database=mysql,puppet=3.0,ruby=1.9.3/testReport/junit/(root)/OperatingsystemTest__families/test_0008_families_as_collection_contains_correct_names_and_values/

dLobatog · 2014-07-17T15:44:42Z

@sergelogvinov the test is still failing as explained above, it's a really minor thing but breaks the suite, let me know when it's fixed. Thanks!

dLobatog · 2014-07-17T18:28:29Z

[test]

dLobatog · 2014-07-17T18:37:04Z

lib/foreman/renderer.rb

@@ -8,7 +8,7 @@ module Renderer
 			:multiboot, :jumpstart_path, :install_path, :miniroot,
 			:media_path, :param_true?, :param_false? ]

-    ALLOWED_VARIABLES = [ :arch, :host, :osver, :mediapath, :static,
+    ALLOWED_VARIABLES = [ :arch, :host, :osver, :mediapath, :madiaserver, :static,


madiaserver -> mediaserver

dLobatog · 2014-07-17T18:41:56Z

@sergelogvinov I'm not sure what you did on the latest commit aside from fixing the OS test, it seems to have gone back in time, and it unsquashed all the commits.

Remember templates are already merged in community-templates here: theforeman/community-templates#86

The Altlinux logo (app/assets/images/Altlinux.png) cannot be included either.

You can see the failed tests here, http://ci.theforeman.org/job/test_develop_pr_core/1603/#showFailuresLink , I think it lacks some permission for the route 'unattended/provision' and removing the templates.

I'm sure you can get back to the point where it was about to get merged by playing around with git a little 😄

dLobatog · 2014-07-17T20:44:05Z

[test]

dLobatog · 2014-07-18T07:10:11Z

@sergelogvinov I was able to recover your branch properly, since it seemed like you did a merge commit, and squashed it.

Merged as 22671c5 , thanks @sergelogvinov and Kot!

GregSutcliffe reviewed Oct 21, 2013
View reviewed changes

domcleal reviewed Oct 21, 2013
View reviewed changes

dLobatog changed the title ~~3377 add altlinux support~~ fixes #3377 - add altlinux support Apr 18, 2014

Kot and others added 8 commits April 27, 2014 19:28

Add altlinux support refs theforeman#3377

b91db59

Deny scm and tar format

8d4c5d1

Add provision templates

d674960

Fix repository host URL

bb3ef6c

Fix altlinux families

530fc67

Cosmetic fix

c5e6d25

Fix rails routes. Match unattended scripts rules for alterator

b83e548

Set default format to html

9acaf32

dLobatog reviewed Jun 18, 2014
View reviewed changes

sergelogvinov added 3 commits June 24, 2014 01:04

Switch templates to unsave mode

6759c38

Cosmetic fix

e4e8af7

Merge remote-tracking branch 'upstream/develop' into 3377-add_altlinu…

6579cb1

…x_support

domcleal assigned dLobatog Jul 10, 2014

domcleal added Needs re-review and removed Waiting on contributor labels Jul 10, 2014

dLobatog added Review done and removed Needs re-review labels Jul 10, 2014

Add os-tests for Altlinux

e4e1afd

dLobatog reviewed Jul 17, 2014
View reviewed changes

Fix os name

9dabda7

dLobatog reviewed Jul 17, 2014
View reviewed changes

sergelogvinov added 2 commits July 17, 2014 23:00

Remove alterator (altlinux) templates

994f837

Change altlinux logo

365106d

dLobatog added Ready to merge and removed Needs testing labels Jul 18, 2014

dLobatog closed this Jul 18, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes #3377 - add altlinux support #966

fixes #3377 - add altlinux support #966

sergelogvinov commented Oct 20, 2013

ohadlevy commented Oct 20, 2013

ohadlevy commented Oct 20, 2013

GregSutcliffe Oct 21, 2013

GregSutcliffe commented Oct 21, 2013

domcleal Oct 21, 2013

domcleal Oct 21, 2013

ohadlevy commented Oct 27, 2013

sergelogvinov commented Oct 27, 2013

ohadlevy commented Oct 27, 2013

sergelogvinov commented Oct 28, 2013

sergelogvinov commented Nov 1, 2013

ohadlevy commented Dec 25, 2013

dLobatog commented Apr 18, 2014

sergelogvinov commented Apr 27, 2014

dLobatog Jun 18, 2014

domcleal commented Jun 23, 2014

sergelogvinov commented Jun 24, 2014

domcleal commented Jul 10, 2014

lzap commented Jul 10, 2014

dLobatog commented Jul 10, 2014

lzap commented Jul 10, 2014

dLobatog commented Jul 17, 2014

dLobatog Jul 17, 2014

dLobatog commented Jul 17, 2014

dLobatog commented Jul 17, 2014

dLobatog Jul 17, 2014

dLobatog commented Jul 17, 2014

dLobatog commented Jul 17, 2014

dLobatog commented Jul 18, 2014

		@@ -0,0 +1,39 @@
		class Altlinux < Operatingsystem

		#PXEFILES = {:kernel => "vmlinuz", :initrd => "full.cz", :stagename => "altinst"}

fixes #3377 - add altlinux support #966

fixes #3377 - add altlinux support #966

Conversation

sergelogvinov commented Oct 20, 2013

ohadlevy commented Oct 20, 2013

ohadlevy commented Oct 20, 2013

GregSutcliffe Oct 21, 2013

Choose a reason for hiding this comment

GregSutcliffe commented Oct 21, 2013

domcleal Oct 21, 2013

Choose a reason for hiding this comment

domcleal Oct 21, 2013

Choose a reason for hiding this comment

ohadlevy commented Oct 27, 2013

sergelogvinov commented Oct 27, 2013

ohadlevy commented Oct 27, 2013

sergelogvinov commented Oct 28, 2013

sergelogvinov commented Nov 1, 2013

ohadlevy commented Dec 25, 2013

dLobatog commented Apr 18, 2014

sergelogvinov commented Apr 27, 2014

dLobatog Jun 18, 2014

Choose a reason for hiding this comment

domcleal commented Jun 23, 2014

sergelogvinov commented Jun 24, 2014

domcleal commented Jul 10, 2014

lzap commented Jul 10, 2014

dLobatog commented Jul 10, 2014

lzap commented Jul 10, 2014

dLobatog commented Jul 17, 2014

dLobatog Jul 17, 2014

Choose a reason for hiding this comment

dLobatog commented Jul 17, 2014

dLobatog commented Jul 17, 2014

dLobatog Jul 17, 2014

Choose a reason for hiding this comment

dLobatog commented Jul 17, 2014

dLobatog commented Jul 17, 2014

dLobatog commented Jul 18, 2014