Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36441 - quote ipv6 addresses #9718

Merged
merged 1 commit into from
May 29, 2023
Merged

Fixes #36441 - quote ipv6 addresses #9718

merged 1 commit into from
May 29, 2023

Conversation

pyslarvt
Copy link
Contributor

Hello. I encountered a bug when foreman shortens an IPv6 address form the end leading to the invalid yaml netpan config. The simple solution is to quote gateway6 and dns6 values.

@theforeman-bot
Copy link
Member

Issues: #36441

adamruzicka
adamruzicka reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this but the proposed changes look sane

ekohl
ekohl previously approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh how I hate YAML's unquoted strings. I'd also consider quoting the static v6, though perhaps the /cidr part forces it to strings, I'd rather be safe than sorry.

@pyslarvt pyslarvt force-pushed the 36441-quote-ipv6-addresses branch from 14314c6 to 0b0a479 Compare May 25, 2023 15:21
@pyslarvt
Copy link
Contributor Author

Oh how I hate YAML's unquoted strings. I'd also consider quoting the static v6, though perhaps the /cidr part forces it to strings, I'd rather be safe than sorry.

Done

@adamruzicka adamruzicka merged commit 9f2c9a0 into theforeman:develop May 29, 2023
7 checks passed
@adamruzicka
Copy link
Contributor

Thank you @pyslarvt !

@pyslarvt pyslarvt deleted the 36441-quote-ipv6-addresses branch May 29, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka left review comments

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Templates
Projects
None yet
Milestone
No milestone
4 participants
@pyslarvt @theforeman-bot @adamruzicka @ekohl