Fixes #36507 - added installable errata count report template #9734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36507 |
wbclark
reviewed
Jun 28, 2023
| <%- load_hosts(search: input('Hosts filter'), preload: [:content_facet]).each_record do |host| -%> | ||
| <%- content_facet = host_content_facet(host) -%> | ||
| <%- | ||
| security_errata_count = content_facet.try(:installable_security_errata_count) |
There was a problem hiding this comment.
This fails with Safemode::NoMethodError: undefined method '#try' for Katello::Host::ContentFacet::Jail (Katello::Host::ContentFacet)
wbclark
reviewed
Jun 28, 2023
Comment on lines
23
to
26
| security_errata_count = content_facet.try(:installable_security_errata_count) | ||
| bugfix_errata_count = content_facet.try(:installable_bugfix_errata_count) | ||
| enhancement_errata_count = content_facet.try(:installable_enhancement_errata_count) | ||
| upgradable_rpm_count = content_facet.try(:upgradable_rpm_count) |
There was a problem hiding this comment.
Suggested change
| security_errata_count = content_facet.try(:installable_security_errata_count) | |
| bugfix_errata_count = content_facet.try(:installable_bugfix_errata_count) | |
| enhancement_errata_count = content_facet.try(:installable_enhancement_errata_count) | |
| upgradable_rpm_count = content_facet.try(:upgradable_rpm_count) | |
| security_errata_count = content_facet ? content_facet.installable_security_errata_count : 0 | |
| bugfix_errata_count = content_facet ? content_facet.installable_bugfix_errata_count : 0 | |
| enhancement_errata_count = content_facet ? content_facet.installable_enhancement_errata_count : 0 | |
| upgradable_rpm_count = content_facet ? content_facet.upgradable_rpm_count : 0 |
This resolved it for me
There was a problem hiding this comment.
@wbclark First of all apologies for the delay, as I was caught up in multiple other tasks. Thanks for the suggestions, I amended the changes that you suggested. When you can please take a look again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New report template to generate the installable errata counts see example below
This PR depends on Katello/katello#10607 for safe mode rendering