Refs #36517 - Correct host search for IPv6 on subnet list #9739
Conversation
|
Issues: #36517 |
| <td> | ||
| <%= | ||
| # TODO: this only works for IPv4 | ||
| count = hosts_count[subnet] |
There was a problem hiding this comment.
I think this comes from:
foreman/app/helpers/application_helper.rb
Lines 327 to 329 in 59bf491
Which in turn comes from HostCounter.
The search linked to subnet.name= instead of subnet6.name, which meant there was nothing found. This doesn't address the bug that it doesn't look at IPv6 subnets for the count.
ekohl
changed the title
| <td><%= link_to_if_authorized(hosts_count[subnet], hash_for_hosts_path(:search => "subnet.name=\"#{subnet}\"")) %> | ||
| <td> | ||
| <%= | ||
| # TODO: https://projects.theforeman.org/issues/36517 this only works for IPv4 |
There was a problem hiding this comment.
This TODO is linked to Redmine for this PR. Shouldn't there be a different Redmine issue?
There was a problem hiding this comment.
I changed this PR to be Refs, because I still think the real issue isn't solved. I could change this to be a unique RM issue just for the broken link, but if the count isn't correct I'm not sure anyone will click on it. The problem is that for every IPv6 subnet the count is 0. After this patch it will link to a listing that may be non-empty, but the label still says 0 so users may not click on it.
|
Thanks @ekohl |
The search linked to subnet.name= instead of subnet6.name, which meant there was nothing found.
This doesn't address the bug that it doesn't look at IPv6 subnets for the count.