Fixes #36550 - Add PermissionDenied to reports tab in host #9763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36550 |
ofedoren
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Thanks, @MariaAga, LGTM and fixes the issue:
Out of the scope: funny thing, I can't find any other usage of PermissionDenied component across the organization... But we have a lot of places which show similar message if the permissions are missing, is there a guide or maybe something that tracks unification for such cases? So each plugin should show the same component.
|
Test failures are unrelated... still. |
|
like where? |
|
adamruzicka
added
the
Needs cherrypick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.