Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36471 - Add eslint rule to alert missing ouia-ids #9765

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fixes #36471 - Add eslint rule to alert missing ouia-ids #9765

merged 1 commit into from
Jul 20, 2023

Conversation

MariaAga
Copy link
Member

And fixing some missing ouia-ids.
Changed lint:spelling to lint:custom as the command just runs all the custom rules defined in .eslintrc

@MariaAga MariaAga requested a review from a team as a code owner June 29, 2023 16:26
@theforeman-bot
Copy link
Member

Issues: #36471

@theforeman-bot
Copy link
Member

Issues: #36471

evgeni
evgeni reviewed Jun 29, 2023
View reviewed changes
package.json
@@ -30,6 +30,7 @@
"@babel/core": "^7.7.0",
"@theforeman/builder": "^12.0.1",
"@theforeman/eslint-plugin-foreman": "^12.0.1",
"@theforeman/eslint-plugin-rules": "^12.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add that to package-exclude.json please :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to submit #9779 for this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhmm, what happened here? It seems to be added here https://github.com/theforeman/foreman/pull/9765/files#diff-97f0a353de600204e809ec124bbc205b69ef828bbad153523a81472cea107aa5R6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think I know what happened. It was removed in the rebase and yesterday I added it because of theforeman/foreman_remote_execution@ab46e19.

I still wonder if the -rules package couldn't have been part of theforeman/eslint-plugin-foreman, saving the whole dance.

evgeni
evgeni approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the packaging part is sane, so ACK on that.

I have no idea about the rest.

@adamruzicka
Copy link
Contributor

@lfu Hi, iirc you were involved in the foreman-js counterpart of this. Could you please take a look?

lfu
lfu approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@lfu lfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@adamruzicka adamruzicka merged commit b657d26 into theforeman:develop Jul 20, 2023
11 checks passed
@adamruzicka
Copy link
Contributor

Thank you @MariaAga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@adamruzicka adamruzicka adamruzicka left review comments

@evgeni evgeni evgeni approved these changes

@lfu lfu lfu approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
6 participants
@MariaAga @theforeman-bot @adamruzicka @evgeni @ekohl @lfu