Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36571 - Remove dividers between navigation items #9768

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fixes #36571 - Remove dividers between navigation items #9768

merged 1 commit into from
Jul 19, 2023

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Jul 5, 2023

before:

image
after:

image

@theforeman-bot
Copy link
Member

Issues: #36571

@adamruzicka
Copy link
Contributor

Should there be dividers between second level items and second level expandable items?

2023-07-19_12-08

@MariaAga
Copy link
Member Author

Yeah, also Maria S approved it here: https://community.theforeman.org/t/rfc-navigation-once-again/33065/23

@adamruzicka
Copy link
Contributor

Very well then, LGTM

@adamruzicka adamruzicka merged commit ec82dea into theforeman:develop Jul 19, 2023
11 checks passed
@adamruzicka
Copy link
Contributor

Thank you @MariaAga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
3 participants
@MariaAga @theforeman-bot @adamruzicka