Refs #36219 - allow loading HashWithIndifferentAccess from YAML

[evgeni]

Fixes: c9b82a5

[theforeman-bot]

Issues: #36219

[evgeni]

The alternative solution would be to make read_metrics not return HWIA, but I wasn't sure the mangling in that function is the only way for the data to get HWIA header, so this seemed safer.

[ofedoren]

A dumb question: since these errors are hard to catch before they come, isn't it better to define permitted classes as a constant and use it everywhere we use safe_load?.. Something like https://github.com/ofedoren/foreman/blob/develop/config/application.rb#L181

[evgeni]

I guess? I was first aiming at fixing the nightly issue (which it does, even if I don't understand why the existing tests didn't catch it before).

[evgeni]

[test katello]

[ekohl]

A dumb question: since these errors are hard to catch before they come, isn't it better to define permitted classes as a constant and use it everywhere we use safe_load?.. Something like https://github.com/ofedoren/foreman/blob/develop/config/application.rb#L181

I think in general you want to limit it as much as possible.

[ekohl]

Not sure if this Katello failure is related. I wouldn't think it is.

[2023-07-31T19:03:20.150Z] Cancelling nested steps due to timeout
[2023-07-31T19:03:20.244Z] Sending interrupt signal to process
[2023-07-31T19:03:25.704Z] AccessPermissionsTest#test_0799_route foreman_tasks/api/tasks/callback should have a permission that grants access rake aborted!
[2023-07-31T19:03:25.704Z] SignalException: SIGTERM

[evgeni]

almost sure it isn't

[test katello]

[ekohl]

Doesn't look like it, merging.