Fixes #3495 - foreman-cli meta-packageshould install hammer #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,10 +116,11 @@ BuildRequires: gettext | |||
| Summary: Foreman CLI | |||
| Group: Applications/System | |||
| Requires: %{name} = %{version}-%{release} | |||
| Requires: %{?scl_prefix}rubygem(foremancli) >= 1.0 | |||
| Requires: %{?scl_prefix}rubygem(hammer_cli) | |||
There was a problem hiding this comment.
You'll need to remove scl_prefix to get the right package.
|
Can we also delete extras/cli/ and the deployment of extras/cli/foremancli from the spec file? |
|
@domcleal thanks for keeping an eye on me ;) Issues fixed. |
pitr-ch
pushed a commit
to pitr-ch/foreman
that referenced
this pull request
Oct 29, 2013
The overall goal was to extract the existing JSON response
overall controllers, and to move them to a seperate name space.
* documentation was added to all requests (available under /apidoc)
this include same request and response generated using
APIPIE_RECORD=examples rake test:api
* Also Fixes theforeman#1800, fixes theforeman#1419, fixes theforeman#981 and fixes theforeman#1774
whats missing:
1. Permissions checks for all new controllers
2. Nested routes (e.g. /hosts/id/reports)
3. running tests with oauth/basic_auth (instead of as_admin {get /})
|
Merged as 16fda03, thanks @mbacovsky! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.