Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36744 - VM tab (legacy UI) shows error in case host is not associated to VM #9832

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

goarsna
Copy link
Contributor

@goarsna goarsna commented Sep 14, 2023

Steps to reproduce:

  1. Register a host
  2. Go to hosts > My_Registered_Host > Dot menu > Legacy UI > VM tab

Actual Result:
An error is shown

Expected result:
Upon registration, the host is not associated to a VM. In case the host is not associated to a VM, the VM tab should not be visible at all.

@theforeman-bot
Copy link
Member

Issues: #36744

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

2 similar comments
@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@stejskalleos
Copy link
Contributor

ok to test

@stejskalleos stejskalleos self-assigned this Oct 30, 2023
@sbernhard
Copy link
Contributor

If the host will associated, the uuid is set: https://github.com/theforeman/foreman/blob/develop/app/models/host/managed.rb#L584
Therefore, in my opinion this check is fine.

@sbernhard
Copy link
Contributor

Thoughs about this @MariaAga ?

@MariaAga
Copy link
Member

MariaAga commented Dec 7, 2023

Are the test failures related?

@m-bucher
Copy link
Contributor

m-bucher commented Dec 7, 2023

Are the test failures related?

@MariaAga I do not think so. In fact I ran them in my forklift and it passed 🤔

bundle exec rails test -v test/controllers/unattended_controller_test.rb
[...]
UnattendedControllerTest::ubuntu#test_0002_should get a preseed finish script with multiple ips in the request header 0.54 = .

Maybe rerun the tests?

@MariaAga MariaAga merged commit 3980566 into theforeman:develop Dec 7, 2023
16 of 17 checks passed
@MariaAga
Copy link
Member

MariaAga commented Dec 7, 2023

All green now, thanks everyone!

@goarsna
Copy link
Contributor Author

goarsna commented Dec 7, 2023

And thanks @MariaAga for merging :)

@m-bucher m-bucher deleted the 36744 branch December 8, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants