Fixes #36847 - Rename initrd for Debian #9870

obol89 · 2023-10-20T09:45:02Z

initrd in official Debian repositories has .gz extension, not .img as it is in the template currently.

theforeman-bot · 2023-10-20T09:45:05Z

Can one of the admins verify this patch?

theforeman-bot · 2023-10-20T09:45:05Z

Can one of the admins verify this patch?

theforeman-bot · 2023-10-20T09:45:05Z

Can one of the admins verify this patch?

ekohl · 2023-10-20T10:53:26Z

ok to test

I've verified the URLs provided in https://projects.theforeman.org/issues/36847 so I think this is correct.

ekohl

Test failures are relevant: the snapshots need to be updated.

sbernhard · 2023-12-05T13:39:02Z

Can you please update the snapshots @obol89

It should only be about these 2 files. Should be easys to update them manually on disk without recording the snapshots completely:

https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.ubuntu4dhcp.snap.txt
https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.debian4dhcp.snap.txt

obol89 · 2023-12-14T09:36:39Z

Can you please update the snapshots @obol89

It should only be about these 2 files. Should be easys to update them manually on disk without recording the snapshots completely:

https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.ubuntu4dhcp.snap.txt https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.debian4dhcp.snap.txt

I just updated the files. I'm not sure if I did it correctly from the merge request / github perspective, but please let me know if there is anything else to do.

sbernhard · 2023-12-28T08:24:16Z

Ready to merge @ekohl ?

ekohl

Checking versions:

So all supported Debian versions have this.

It's also weird we have a line initrd below it which is correct. Looks like the specific line was introduced in 91de027. That came from theforeman/community-templates@8deda37. In theforeman/community-templates#496 it is explicitly discussed, but I suppose nobody verified it for Debian.

ekohl · 2024-01-02T15:19:21Z

...reman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.debian4dhcp.snap.txt

@@ -5,7 +5,7 @@ echo Trying to ping DNS: ${netX/dns}
 ping --count 1 ${netX/dns} || echo Ping to DNS failed or ping command not available.


-kernel http://ftp.debian.org/debian/dists/wheezy/main/installer-amd64/current/images/netboot/debian-installer/amd64/linux initrd=initrd.img interface=auto url=http://foreman.example.com/unattended/provision ramdisk_size=10800 root=/dev/rd/0 rw auto BOOTIF=01-${netX/mac:hexhyp} auto=true netcfg/disable_dhcp=false locale=en_US hostname=snapshot-ipv4-dhcp-deb10 domain=snap.example.com
+kernel http://ftp.debian.org/debian/dists/wheezy/main/installer-amd64/current/images/netboot/debian-installer/amd64/linux initrd=initrd.gz interface=auto url=http://foreman.example.com/unattended/provision ramdisk_size=10800 root=/dev/rd/0 rw auto BOOTIF=01-${netX/mac:hexhyp} auto=true netcfg/disable_dhcp=false locale=en_US hostname=snapshot-ipv4-dhcp-deb10 domain=snap.example.com


We should really update our tests to have something newer than Wheezy, but that's outside the scope of this PR so I opened #9972.

ekohl · 2024-01-02T15:23:00Z

app/views/unattended/provisioning_templates/iPXE/preseed_default_ipxe.erb

@@ -36,7 +36,7 @@ ping --count 1 ${netX/dns} || echo Ping to DNS failed or ping command not availa
 <% kernel = boot_files_uris[0] -%>
 <% initrd = boot_files_uris[1] -%>

-kernel <%= kernel %> initrd=initrd.img interface=auto url=<%= url %> ramdisk_size=10800 root=/dev/rd/0 rw auto <%= snippet("preseed_kernel_options", variables: {ipxe_net: true}).strip %>
+kernel <%= kernel %> initrd=initrd.gz interface=auto url=<%= url %> ramdisk_size=10800 root=/dev/rd/0 rw auto <%= snippet("preseed_kernel_options", variables: {ipxe_net: true}).strip %>


Why doesn't this use the initrd variable that's defined on line 37? Shouldn't it be:

Suggested change

kernel <%= kernel %> initrd=initrd.gz interface=auto url=<%= url %> ramdisk_size=10800 root=/dev/rd/0 rw auto <%= snippet("preseed_kernel_options", variables: {ipxe_net: true}).strip %>

kernel <%= kernel %> initrd=<%= initrd %> interface=auto url=<%= url %> ramdisk_size=10800 root=/dev/rd/0 rw auto <%= snippet("preseed_kernel_options", variables: {ipxe_net: true}).strip %>

I'd expect it to then correctly use this code:

foreman/app/models/operatingsystems/debian.rb

Line 2 in a1142ab

PXEFILES = {:kernel => "linux", :initrd => "initrd.gz"}

ekohl · 2024-01-02T15:23:06Z

...reman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.ubuntu4dhcp.snap.txt

@@ -5,7 +5,7 @@ echo Trying to ping DNS: ${netX/dns}
 ping --count 1 ${netX/dns} || echo Ping to DNS failed or ping command not available.


-kernel http://archive.ubuntu.com/ubuntu/dists/focal/main/installer-amd64/current/images/netboot/ubuntu-installer/amd64/linux initrd=initrd.img interface=auto url=http://foreman.example.com/unattended/provision ramdisk_size=10800 root=/dev/rd/0 rw auto BOOTIF=01-${netX/mac:hexhyp} console-setup/ask_detect=false console-setup/layout=USA console-setup/variant=USA keyboard-configuration/layoutcode=us localechooser/translation/warn-light=true localechooser/translation/warn-severe=true netcfg/disable_dhcp=false locale=en_US hostname=snapshot-ipv4-dhcp-ubuntu18 domain=snap.example.com


Confusingly enough, this combination is never valid. For Focal you only have legacy-images and that directory only has boot.img.gz, not initrd.*.

github-actions · 2024-04-10T01:46:12Z

Thank you for your contribution! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.

ekohl · 2024-04-26T08:57:40Z

I'm going to reopen this because I think it's still needed.

sbernhard · 2024-05-10T12:33:31Z

[test]

ekohl · 2024-05-10T13:18:03Z

I opened #10156 with #9870 (comment) and resolved the merge conflicts.

Fixes #36847 - Rename initrd for Debian

d909a01

pr-processor bot added the Not yet reviewed label Oct 20, 2023

github-actions bot added the Templates label Oct 20, 2023

ekohl approved these changes Oct 20, 2023

View reviewed changes

pr-processor bot removed the Not yet reviewed label Oct 20, 2023

stejskalleos assigned ekohl and sbernhard Oct 30, 2023

sbernhard previously approved these changes Oct 30, 2023

View reviewed changes

ekohl requested changes Oct 30, 2023

View reviewed changes

pr-processor bot added the Waiting on contributor label Oct 30, 2023

Change initrd.img to initrd.gz

fec211f

obol89 dismissed sbernhard’s stale review via fec211f December 14, 2023 09:35

pr-processor bot added the Needs re-review label Dec 14, 2023

Change initrd.img to initrd.gz

f3c65ed

sbernhard approved these changes Dec 22, 2023

View reviewed changes

pr-processor bot removed the Needs re-review label Dec 22, 2023

ekohl requested changes Jan 2, 2024

View reviewed changes

github-actions bot added the Stale label Apr 2, 2024

github-actions bot added the Inactive label Apr 10, 2024

github-actions bot closed this Apr 10, 2024

ekohl reopened this Apr 26, 2024

github-actions bot removed Inactive Stale labels Apr 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #36847 - Rename initrd for Debian #9870

Fixes #36847 - Rename initrd for Debian #9870

obol89 commented Oct 20, 2023

theforeman-bot commented Oct 20, 2023

theforeman-bot commented Oct 20, 2023

theforeman-bot commented Oct 20, 2023

ekohl commented Oct 20, 2023

ekohl left a comment

sbernhard commented Dec 5, 2023 •

edited

obol89 commented Dec 14, 2023

sbernhard commented Dec 28, 2023

ekohl left a comment

ekohl Jan 2, 2024

ekohl Jan 2, 2024

ekohl Jan 2, 2024

github-actions bot commented Apr 10, 2024

ekohl commented Apr 26, 2024

sbernhard commented May 10, 2024

ekohl commented May 10, 2024

	kernel <%= kernel %> initrd=initrd.gz interface=auto url=<%= url %> ramdisk_size=10800 root=/dev/rd/0 rw auto <%= snippet("preseed_kernel_options", variables: {ipxe_net: true}).strip %>
	kernel <%= kernel %> initrd=<%= initrd %> interface=auto url=<%= url %> ramdisk_size=10800 root=/dev/rd/0 rw auto <%= snippet("preseed_kernel_options", variables: {ipxe_net: true}).strip %>

		@@ -5,7 +5,7 @@ echo Trying to ping DNS: ${netX/dns}
		ping --count 1 ${netX/dns} \|\| echo Ping to DNS failed or ping command not available.


		kernel http://archive.ubuntu.com/ubuntu/dists/focal/main/installer-amd64/current/images/netboot/ubuntu-installer/amd64/linux initrd=initrd.img interface=auto url=http://foreman.example.com/unattended/provision ramdisk_size=10800 root=/dev/rd/0 rw auto BOOTIF=01-${netX/mac:hexhyp} console-setup/ask_detect=false console-setup/layout=USA console-setup/variant=USA keyboard-configuration/layoutcode=us localechooser/translation/warn-light=true localechooser/translation/warn-severe=true netcfg/disable_dhcp=false locale=en_US hostname=snapshot-ipv4-dhcp-ubuntu18 domain=snap.example.com

Fixes #36847 - Rename initrd for Debian #9870

Are you sure you want to change the base?

Fixes #36847 - Rename initrd for Debian #9870

Conversation

obol89 commented Oct 20, 2023

theforeman-bot commented Oct 20, 2023

theforeman-bot commented Oct 20, 2023

theforeman-bot commented Oct 20, 2023

ekohl commented Oct 20, 2023

ekohl left a comment

Choose a reason for hiding this comment

sbernhard commented Dec 5, 2023 • edited

obol89 commented Dec 14, 2023

sbernhard commented Dec 28, 2023

ekohl left a comment

Choose a reason for hiding this comment

ekohl Jan 2, 2024

Choose a reason for hiding this comment

ekohl Jan 2, 2024

Choose a reason for hiding this comment

ekohl Jan 2, 2024

Choose a reason for hiding this comment

github-actions bot commented Apr 10, 2024

ekohl commented Apr 26, 2024

sbernhard commented May 10, 2024

ekohl commented May 10, 2024

sbernhard commented Dec 5, 2023 •

edited