Fixes #36892 - Pass host results to REX slot and make permissions nodes extensible #9895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
force-pushed
the
36892-add-results-to-slot
branch
3 times, most recently
from
bd47581
to
519f91a
Compare
jeremylenz
force-pushed
the
36892-add-results-to-slot
branch
4 times, most recently
from
8c0bfb1
to
3aeaf33
Compare
jeremylenz
changed the title
jeremylenz
force-pushed
the
36892-add-results-to-slot
branch
from
3aeaf33
to
23dde58
Compare
parthaa
reviewed
Nov 21, 2023
|
[test katello] |
allow root node permissions to be extended Refs #36892 - improvements to regex & index layout
jeremylenz
force-pushed
the
36892-add-results-to-slot
branch
from
23dde58
to
9c1c7b5
Compare
|
@parthaa updated to use your implementation of |
ianballou
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Tested with theforeman/foreman_remote_execution#845 and I was able to run a bulk host action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foreman_remote_execution needs access to the host response on the new host overview page (without making another api request).
This also allows plugins to override an
index_node_permissionsmethod to add permissions of their own to the API response.