Fixes #36963 - Table index new button far in large screens #9945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaAga
commented
Dec 5, 2023
| @@ -15,4 +15,7 @@ | |||
| .pf-c-dropdown.pf-m-align-right { | |||
| width: unset; | |||
| } | |||
| .pf-c-dropdown { | |||
| width: unset; // just in case Katello overrides it | |||
There was a problem hiding this comment.
It shouldnt now Katello/katello#10748
kmalyjur
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Awesome! I was maybe thinking that 8px looks better than 16px (according to Patternfly it can be 8 if it's in the toolbar next to the icon button), but it's probably just personal preference. Other than that LGTM.
|
Thanks! I'm using the design from https://www.sketch.com/s/7c65523b-3b2b-4fbd-b785-9d323dac6b95/a/52Ryg1P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After