Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36966 - broken link in Register Host documentation #9946

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fixes #36966 - broken link in Register Host documentation #9946

merged 1 commit into from
Dec 7, 2023

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Dec 6, 2023

in Register Host page, the documentation button is using getDocsURL.

@github-actions github-actions bot added the UI label Dec 6, 2023
kmalyjur
kmalyjur approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@kmalyjur kmalyjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - works as it should, LGTM

ofedoren
ofedoren approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga, another candidate for a CP?

@ofedoren ofedoren merged commit be98675 into theforeman:develop Dec 7, 2023
22 checks passed
@ofedoren ofedoren added the Needs cherrypick This should be cherrypicked to the stable branches or branches label Dec 7, 2023
@ekohl
Copy link
Member

ekohl commented Dec 19, 2023

Oops, my bad. I introduced this in b566ea8. Since that was introduced in Foreman 3.9 this commit should have been Refs #32848 instead of Fixes #36966 so they're properly related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofedoren ofedoren ofedoren approved these changes

@kmalyjur kmalyjur kmalyjur approved these changes

Assignees
No one assigned
Labels
Needs cherrypick This should be cherrypicked to the stable branches or branches UI
Projects
None yet
Milestone
No milestone
4 participants
@MariaAga @ekohl @ofedoren @kmalyjur