Fixes #36997 - Use selenium_chrome_headless for integration tests #9962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we configure selenium_chrome to be headless, unless some parameter is given. It's better to use selenium_chrome_headless instead and have users select the selenium_chrome driver if they need to debug it. See https://github.com/teamcapybara/capybara#selenium for the built in ones.
dosas
reviewed
Dec 20, 2023
| Capybara.configure do |config| | ||
| config.javascript_driver = ENV["JS_TEST_DRIVER"]&.to_sym || :selenium_chrome | ||
| config.javascript_driver = ENV.fetch("JS_TEST_DRIVER") { ENV['DEBUG_JS_TEST'] ? :selenium_chrome : :selenium_chrome_headless }.to_sym |
There was a problem hiding this comment.
We should probably also adapt this line https://github.com/theforeman/foreman/blob/develop/test/integration_test_helper.rb#L302
When not set to the correct JS_TEST_DRIVER (:selnium_chorme, :selenium_chrome_headless, :selenium_chrome_remote) it throws the following error:
ShowMeTheCookies::SeleniumSiteNotVisitedError: Can't set a cookie on about:blank. Visit a url in your app first.
test/integration_test_helper.rb:330:in `set_request_user'
test/integration_test_helper.rb:321:in `login_admin'
test/test_helper.rb:73:in `before_setup'
test/integration_test_helper.rb:348:in `before_setup'
Maybe the if clause in L302 can even be removed?
|
Any news on this? |
|
Changes implemented here #9952 can be closed with sufficient rights |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we configure selenium_chrome to be headless, unless some parameter is given. It's better to use selenium_chrome_headless instead and have users select the selenium_chrome driver if they need to debug it.
See https://github.com/teamcapybara/capybara#selenium for the built in ones.
The inspiration for this was #9952.