Fixes #37043 - Inheritance overrides host facets

[ananace]

No description provided.

[jeremylenz]

Will this affect the behavior of Katello/katello#10841 ?

cc @parthaa @qcjames53

[qcjames53]

I'm not entirely sure to be honest. My hunch is we should be ok since I'm removing the apply_inherited_attributes method from Katello entirely. Once I finish up the new unit tests I'll run this PR through to see if anything breaks.

[ananace]

@ShimShtein

[ShimShtein]

Left a comment to fix the explicit nil use case.

Also can we add some tests to https://github.com/theforeman/foreman/blob/develop/test/unit/facet_test.rb to specify this behavior?

[ananace]

Redid merge code and added tests for both overriding with an actual value as well as with nil.

I don't know if the merge result will be exactly as expected with every potential mix of strings/symbols, but I wasn't able to make it misbehave in the tests, so I decided to skip slapping with_indifferent_access on everything.

[ShimShtein]

@qcjames53 were you able to finish the unit tests? I would like to run this PR there just to be sure I am not missing some use case.

Otherwise LGTM.

[qcjames53]

Hey @ShimShtein. The changes are merged into master branch Katello; you should be all good to go.

[jeremylenz]

[test katello]

[ShimShtein]

Merged, thanks @ananace !