Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21528 - start using factory bot #104

Merged
merged 1 commit into from Nov 2, 2017
Merged

Fixes #21528 - start using factory bot #104

merged 1 commit into from Nov 2, 2017

Conversation

ares
Copy link
Member

@ares ares commented Nov 1, 2017

No description provided.

tbrisker
tbrisker approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ares
Copy link
Member Author

ares commented Nov 1, 2017

rubocop needs to be updated first

@ares ares mentioned this pull request Nov 1, 2017
Merged
dLobatog
dLobatog approved these changes Nov 2, 2017
View reviewed changes
Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if tests pass, thanks @ares

@ares
Copy link
Member Author

ares commented Nov 2, 2017

I'm afraid master test won't run anymore (there's no FactoryGirl anymore) and the jenkins job to test custom PRs seems to be broken. @dLobatog could you please run test manually and merge if they are green?

This is how it looks locally

.............................................................................

Finished in 10.843113s, 7.1013 runs/s, 14.9404 assertions/s.
77 runs, 162 assertions, 0 failures, 0 errors, 0 skip

@dLobatog dLobatog merged commit 0fdc10b into theforeman:master Nov 2, 2017
@dLobatog
Copy link
Member

dLobatog commented Nov 2, 2017

Thanks @ares !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dLobatog dLobatog dLobatog approved these changes

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
4 participants
@ares @dLobatog @tbrisker @theforeman-bot