Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24038 - don't display host roles in hg form #182

Merged
merged 1 commit into from Jul 13, 2018

Conversation

ares
Copy link
Member

@ares ares commented Jul 4, 2018

all_ansible_roles method of hostgroup also loads roles from hosts, this is used e.g. when we decide whether to display "Play roles" button for hostgroup. For displaying selected records, we only need to load hostgroup's roles and all roles inherited from its parents.

Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some tests are failing, could you take a look?

Thanks @ares !

@ares
Copy link
Member Author

ares commented Jul 11, 2018

Ah that was a silly typo, should be fixed now

Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures look unrelated, thanks @ares

@dLobatog dLobatog merged commit aca8166 into theforeman:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants