Fixes #23741 - Associate hostname to reports created by IP #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dLobatog
commented
Jul 12, 2018
dLobatog
force-pushed
the
23741
branch
4 times, most recently
from
bae56e7
to
71a7f8b
Compare
dLobatog
commented
Jul 12, 2018
There was a problem hiding this comment.
@ares @bastilian Alright - I think this is now ready for review
Steps to reproduce: 1 set setting remote_execution_connect_by_ip to true 2 run Ansible job 3 search for reports at the host Before: no reports found for the host, new host created with the name of the IP, with the reports assigned After: The original host gets the reports assigned
|
All green, thank you, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
1 set setting remote_execution_connect_by_ip to true
2 run Ansible job
3 search for reports at the host
Before: no reports found for the host, new host created with the
name of the IP, with the reports assigned
After: The original host gets the reports assigned
--- still needs tests