Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24487 - Ansible Variables API #195

Merged
merged 1 commit into from Oct 23, 2018
Merged

Conversation

dLobatog
Copy link
Member

CRUD operations + import/obsolete for Ansible Variables. Lookup Values
can be set through the Foreman API already.

Do not merge yet, this has only been tested manually. Make sure to merge after #193 is merged & rebase this PR against master when that happens.

Copy link
Member Author

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to include permissions

CRUD operations + import/obsolete for Ansible Variables. Lookup Values
can be set through the Foreman API already.
Copy link
Member Author

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastilian @ares Rebased and ready to review!

@xprazak2
Copy link
Contributor

Works for me.

Copy link
Member Author

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xprazak2 for reviewing

@dLobatog dLobatog merged commit e4556a3 into theforeman:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants