Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25741 - remove leftover requirement #229

Merged
merged 1 commit into from Jan 10, 2019
Merged

Conversation

ares
Copy link
Member

@ares ares commented Dec 20, 2018

No description provided.

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and doesn't seem to break anything, ACK

@mmoll
Copy link
Contributor

mmoll commented Dec 20, 2018

test failures related 💔

@adamruzicka
Copy link
Contributor

Test failures are related. In foreman-tasks we setup the settings for *Core plugins in an initializer[1]. By moving the require 'foreman_ansible_core into test_plugin_helper.rb the settings dont get set up correctly (test_plugin_helper being loaded after the initializer was run?)

[1] - https://github.com/theforeman/foreman-tasks/blob/master/lib/foreman_tasks/engine.rb#L134

@ares
Copy link
Member Author

ares commented Jan 4, 2019

modified so we require only in test env, 🤞

@adamruzicka
Copy link
Contributor

The should fetch failures appear in other PRs too so those are most likely unrealted, not 100% sure if the should create with recurrence falls in the same boat

@ares
Copy link
Member Author

ares commented Jan 4, 2019

let's see [test foreman_ansible]

@mmoll
Copy link
Contributor

mmoll commented Jan 6, 2019

seems consistently 💔
EDIT: OK, the one that happens consistenly is the known one.

@ares
Copy link
Member Author

ares commented Jan 7, 2019

Api::V2::AnsibleRolesControllerTest.test_0003_should fetch is unrelated as it can be observed in other PRs too, e.g. #229

@ares
Copy link
Member Author

ares commented Jan 10, 2019

Thanks for taking a look, merging to unblock 2.3.1 release.

@ares ares merged commit 6a78d7e into theforeman:master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants