Use absolute_import for foreman_callback plugin #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansible plugin directory contains `json` callback plugin next to foreman_callback plugin. Without absolute import foreman_callback plugin fails with json errors (which occurs due to namespace collision). Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
Do not merge! This patch has not been tested yet. Can an existing organization member please verify this patch? |
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
|
ok to test |
|
We removed the callback from our repo in #358 , so I'll go ahead and close this. We now favor the callback from foreman ansible modules where the change you were proposing is already present. Thank you @Akasurde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible plugin directory contains
jsoncallback plugin next toforeman_callback plugin. Without absolute import foreman_callback
plugin fails with json errors (which occurs due to namespace collision).
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com