Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #27445 - Properly serialize default var values #293

Merged
merged 2 commits into from Sep 9, 2019

Conversation

xprazak2
Copy link
Contributor

No description provided.

Copy link
Contributor

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thanks @xprazak2

@adamruzicka
Copy link
Contributor

Could you rebase? It should make the rubocop issues go away

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 66d9d21 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@ares
Copy link
Member

ares commented Sep 9, 2019

[test Redmine issues]

@ares
Copy link
Member

ares commented Sep 9, 2019

works fine, let's see the test output

@ares
Copy link
Member

ares commented Sep 9, 2019

REX tests fail but not related, merging, thanks @xprazak2

@ares ares merged commit bc3fbeb into theforeman:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants