Fixes #27663 - Make ansible var keys unique #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xprazak2
force-pushed
the
ansvar-unique
branch
from
74adc28
to
e211ad1
Compare
|
LGTM, can you rebase and get those tests passing? Many of them are failing. |
|
this seems as rex failures though (dependency of the plugin), I don't think it would be related to this PR |
xprazak2
force-pushed
the
ansvar-unique
branch
from
e211ad1
to
9204693
Compare
|
Test failures should be fixed with the new rex release: theforeman/foreman_remote_execution@c8afb22 |
|
[test foreman_ansible] |
|
There are still some REX issues, but unrelated to this patch. Tested it and it works, merging 👍 |
ares
pushed a commit
that referenced
this pull request
Sep 9, 2019
(cherry picked from commit f36b9f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.