Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28463 - Fix missing roles in the assigned roles list #318

Merged
merged 2 commits into from Dec 13, 2019
Merged

Fixes #28463 - Fix missing roles in the assigned roles list #318

merged 2 commits into from Dec 13, 2019

Conversation

amasolov
Copy link
Contributor

Needed to populate directlyAssignedRoles with allAssignedRoles instead of assignedRoles to get the whole list of roles not just visible ones.

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@amasolov
Copy link
Contributor Author

Fixed my own mess with commits. Should be fine now.

@amasolov amasolov reopened this Dec 12, 2019
@amasolov
Copy link
Contributor Author

Looks like this PR also fixes #27678. Can't reproduce the described problem after applying this change.

@xprazak2
Copy link
Contributor

Good catch. You need to pass allAssignedRoles as a prop to the AssignedRolesList to propagate it from a parent component though:

<AssignedRolesList
  allAssignedRoles={allAssignedRoles}
//other props
/>

@amasolov
Copy link
Contributor Author

You need to pass allAssignedRoles as a prop to the AssignedRolesList

Yup, somehow missed that in my commit.

@xprazak2 xprazak2 merged commit 7a8e86e into theforeman:master Dec 13, 2019
@xprazak2
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants