Check to see if variables is nil before proceeding #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Another user in the linked forums post confirmed that it worked. |
|
Looks reasonable, could you please open a redmine issue with a description and update commit message to a format "Fixes #123 - ..."? If you can't or don't know how, please let us know. |
|
[test foreman_ansible] |
…through the Foreman UI
Check to see if variables is nil before proceeding
Ref: https://community.theforeman.org/t/openscap-plugin-with-ansible-role-variables-import-failed/16601
When attempting ansible variables import through the Foreman UI, there is a case where
clicking Configure > Ansible Variables > Import from <foreman> will fail. The error that gets
thrown is the following:
*NoMethodError*
**undefined method `map' for nil:NilClass**
/opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-3.0.9/app/services/foreman_ansible/variables_importer.rb:48:in `initialize_variables'
/opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-3.0.9/app/services/foreman_ansible/variables_importer.rb:34:in `block in import_variables'
/opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-3.0.9/app/services/foreman_ansible/variables_importer.rb:31:in `each'
/opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-3.0.9/app/services/foreman_ansible/variables_importer.rb:31:in `map'
/opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-3.0.9/app/services/foreman_ansible/variables_importer.rb:31:in `import_variables'
/opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-3.0.9/app/services/foreman_ansible/variables_importer.rb:25:in `import_variable_names'
This commit will skip those nil variables, which then makes Foreman operate as expected.
|
Okay, I updated the commit message. Thanks! |
|
Thanks @dtibarra, merging! Test failures were unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://community.theforeman.org/t/openscap-plugin-with-ansible-role-variables-import-failed/16601
When attempting ansible variables import through the Foreman UI, there is a case where
clicking Configure > Ansible Variables > Import from Foreman will fail. The error that gets
thrown is the following:
This commit will skip those nil variables, which then makes Foreman operate as expected.