Fixes #29343 - update Ansible Inventory template name #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foreman 2.1 will probably contain a change that renames the inventory report template, thanks to the mass renaming in theforeman/community-templates#680 We have the name set as the default value in Settings. For people who didn't change it, changing the default will do. For people who changed the value to some other template, their value remains unchanged, which is expected. No more actions are needed therefore.
|
This should only be merged when theforeman/community-templates#680 gets synced to Foreman core. We'll need to bump foreman min version accordingly, most likely to |
|
I guess we wait for theforeman/foreman#7532 as well? |
This is now in. [test foreman_ansible] |
|
This didn't get into the repository for some reason and only got fixed in #342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foreman 2.1 will probably contain a change that renames the inventory
report template, thanks to the mass renaming in theforeman/community-templates#680
We have the name set as the default value in Settings. For people who
didn't change it, changing the default will do. For people who changed
the value to some other template, their value remains unchanged, which
is expected. No more actions are needed therefore.