Fixes #30384 - Fix ansible secrets to support effective_user_password #350
Conversation
|
Can one of the admins verify this patch? |
|
This change is required because of - theforeman/foreman_remote_execution#508 |
| def rex_ssh_password(host) | ||
| host_setting(host, 'remote_execution_ssh_password') | ||
| end |
There was a problem hiding this comment.
Do we really want to do this? The ssh password can still be different from the effective user one
There was a problem hiding this comment.
Yeah, I should only change sudo_pass. Got confused in ansible_ssh_pass and ansible_su_pass. :P
But I think we should change ansible variable from "ansible_sudo_pass" to "ansible_become_password", it will help to deal with both sudo and su user method.
I will add the ansible_ssh_pass again.
|
The changes in rex will be released in 4.0.0, could you bump the versions in gemspec here? |
patilsuraj767
force-pushed
the
change-ansible-secrets
branch
from
bf95a0d
to
9c8eeb1
Compare
theforeman-bot
added
Needs re-review
Waiting on contributor
and removed
Waiting on contributor
labels
| def rex_sudo_password(host) | ||
| host_setting(host, 'remote_execution_sudo_password') | ||
| def rex_effective_user_password(host) | ||
| host_setting(host, 'remote_execution_effective_user_password') |
There was a problem hiding this comment.
Doesn't this imply a migration of old settings is necessary?
We need migration to rename setting like this:
Setting.where(name: 'remote_execution_sudo_password').update_all(name: 'remote_execution_effective_user_password')
There was a problem hiding this comment.
@ezr-ondrej Migration is written in this PR - theforeman/foreman_remote_execution#508
There was a problem hiding this comment.
Right 👍 Thanks for the pointer, missed that out. In that case no more picks.
|
@adamruzicka this should get in before release for foreman 2.2, right? |
|
Ideally, yes. The changes in rex will go out in 4.0.0, which will be the first >=2.2 release |
|
Looks like one of these tests is now failing: https://ci.theforeman.org/job/test_plugin_matrix/2441/ |
|
Being handled here #360 |
No description provided.