Refs #31980 - improve Ansible as authorized feature #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, my bad - Ther's still so much I don't know about Ruby! Thanks for the fix. |
ezr-ondrej
force-pushed
the
authorized_features_test
branch
from
040c920
to
4cc3e0e
Compare
No worries this is quite a strange ruby behaviour. |
In 1b90f87 we allowed Ansible as authorized feature on smart proxy, but we acutally overriden the Array so Puppet wouldn't be authorized_feature. Also adding a test that config report can be created with proxy only having Ansible feature.
ezr-ondrej
force-pushed
the
authorized_features_test
branch
from
4cc3e0e
to
98367da
Compare
|
This has been fixed by #491, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1b90f87 we allowed Ansible as
authorized feature on smart proxy, but we acutally overriden the Array
so Puppet wouldn't be authorized_feature.
Also adding a test that config report can be created with proxy only
having Ansible feature.