Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #34713 - Replace pf3 OverlayTrigger #524

Merged
merged 2 commits into from Apr 14, 2022
Merged

Refs #34713 - Replace pf3 OverlayTrigger #524

merged 2 commits into from Apr 14, 2022

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Apr 5, 2022

No description provided.

@ezr-ondrej
Copy link
Member

Can we have a separate Redmine ticket for this and link it to the original one?

@MariaAga
Copy link
Member Author

MariaAga commented Apr 5, 2022

Yeah added a redmine, and renamed margin-right to marginRight

stejskalleos
stejskalleos requested changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@stejskalleos stejskalleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ LGTM, tested the code and it works very well.

The only thing is the commit message, @MariaAga could you please update the commit message as Fixes #000 - message?

After that PR will be ready to go!

@stejskalleos stejskalleos merged commit 8cc3e7e into theforeman:master Apr 14, 2022
@stejskalleos
Copy link
Contributor

Thanks @MariaAga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stejskalleos stejskalleos stejskalleos requested changes

Assignees
No one assigned
Labels
Needs re-review Needs testing
Projects
None yet
Milestone
No milestone
4 participants
@MariaAga @ezr-ondrej @stejskalleos @theforeman-bot