Fixes #35317 - The icon is part of foreman core now. #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icon on the config management reports page is not shown because it tries to show the icon in foreman_ansible plugin directory. The icon was moved to foreman core month ago.
sbernhard
changed the title
Ron-Lavi
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon on the config management reports page is not shown because it
tries to show the icon in foreman_ansible plugin directory. The icon was
moved to foreman core month ago.
The method in https://github.com/theforeman/foreman/blob/f28bc34cc749886b80f8b0f909438118368c6040/app/helpers/reports_helper.rb#L60 will use "Ansible.png" (part of foreman itself) instead of calling the helper method ansible_report_origin_icon