Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #35970 - add orcharhino branding to upgrading Smart Proxies #586

Closed
wants to merge 4 commits into from
Closed

Fixes #35970 - add orcharhino branding to upgrading Smart Proxies #586

wants to merge 4 commits into from

Conversation

maximiliankolb
Copy link

@maximiliankolb maximiliankolb marked this pull request as draft January 20, 2023 10:07
@maximiliankolb
Copy link
Author

How should I handle commits that "prepare" my actual change?

@ehelms
Copy link
Member

ehelms commented Feb 2, 2023

I would recommend taking a look at #590 -- it will force you to a rebase. I think your original design can still work, that is, attaching your changes as an if/else to the smart proxy playbook rather than the Capsule upgrade playbook. Or you could opt to have your own template in a similar fashion.

@maximiliankolb
Copy link
Author

Thanks Eric, I will wait for your PR to get merged first & then rebase.

@maximiliankolb
Copy link
Author

I have rebased my PR but I'm still waiting for internal feedback. Please consider this PR a draft for now.

@nofaralfasi
Copy link
Contributor

Upon reviewing the PR, it seems that it has been open for quite some time without recent activity. In order to keep our repository organized and up-to-date, we've decided to close this draft PR for now.
Feel free to reopen it if you decide to continue this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Not yet reviewed Waiting on contributor
Projects
None yet
Milestone
No milestone
4 participants
@maximiliankolb @ehelms @nofaralfasi @theforeman-bot