Fixes #35885 - Error printing report with multiple results (#583) #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nofaralfasi
force-pushed
the
bump_10-3-0
branch
from
cf4ab45
to
e91e0d2
Compare
…n#583) * Fixes #35885 - Error printing report with multiple results If Ansible job reported more than one results per action then the config report page will fail to render. For example, a task uses the Ansible copy module to copy multiple files in a loop. * Refs #35885 - fix rubocop issue RuboCop::Cop::Lint::ShadowingOuterLocalVariable module_args was in the `ansible_module_message` method scop, and also as a parameter in the `get_results` function's signature decided to remove the first definition of it as it wasn't used. * Refs #35885 - `end` was ommited during rebase * Refs #35885 - fix tests undefined method `[]' for nil:NilClass in case that `result['invocation']` is nil: foreman_ansible/app/helpers/foreman_ansible/ansible_reports_helper.rb:98:in `block in get_results' Co-authored-by: Ron Lavi <1ronlavi@gmail.com> (cherry picked from commit ed16127)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit ed16127)