Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36046 - Update pf4 to 2022.16+ release #598

Merged
merged 1 commit into from Feb 20, 2023
Merged

Fixes #36046 - Update pf4 to 2022.16+ release #598

merged 1 commit into from Feb 20, 2023

Conversation

MariaAga
Copy link
Member

because of "@theforeman/vendor": ">= 8.16.0" the datepicker is already broken to anyone who ran npm i in the last week, fixing it here.

@nofaralfasi
Copy link
Contributor

Thanks @MariaAga, it works for me. Can you just fetch the changes from master and rebase, so I can get it into the next release?

@MariaAga
Copy link
Member Author

rebased

@MariaAga
Copy link
Member Author

Are the test failures related?

@nofaralfasi
Copy link
Contributor

Are the test failures related?

No :)

@nofaralfasi
Copy link
Contributor

Thanks @MariaAga!

@nofaralfasi nofaralfasi merged commit d0171a9 into theforeman:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nofaralfasi nofaralfasi nofaralfasi left review comments

Assignees
No one assigned
Labels
Not yet reviewed
Projects
None yet
Milestone
No milestone
3 participants
@MariaAga @nofaralfasi @theforeman-bot