Fixes #36569 - List only supported Job Templates on upstream

[nofaralfasi]

No description provided.

[stejskalleos]

What if instead of this we update the db seed for the Ansible job templates?

    JobTemplate.without_auditing do
      Dir[File.join("#{ForemanAnsible::Engine.root}/app/views/foreman_ansible/"\
                    'job_templates/**/*.erb')].each do |template|
        sync = !Rails.env.test? && Setting[:remote_execution_sync_templates]
        template = JobTemplate.import_raw!(File.read(template),
                                           :default => true,
                                           :lock => true,
                                           :update => sync)
        template.organizations = organizations if template.present?
        template.locations = locations if template.present?
      end

[nofaralfasi]

If my understanding is correct, this code block is responsible for importing new templates and storing them in the database. However, as the Capsule Upgrade Playbook already exists in our database, we must create a migration to remove it, in addition to making changes in the code. The same process applies to handling the Smart Proxy Upgrade Playbook in the reverse scenario for the downstream.

On one hand, this approach ensures that unsupported job templates are not saved in the database, thereby avoiding the need for further code changes in the API. However, on the other hand, it requires the necessary migrations to delete data.

@ShimShtein, would you like to share your thoughts on this matter?

[stejskalleos]

However, as the Capsule Upgrade Playbook already exists in our database, we must create a migration to remove it, in addition to making changes in the code.

Do we need migration? Was it released to production already? In downstream it wasn't, not sure about the upstream.

[nofaralfasi]

AFAIK, it was released both downstream and upstream.
10.4.2 (downstream, foreman 3.5), 11.1.1 (foreman 3.6, foreman 3.7).

[ShimShtein]

Removing the template in seeds/migrations seems more clean, but we will need a code that explicitly removes the unwanted template there.
Something like:

unsupported_templates = ['capsule_upgrade.erb']
unsupported_templates = ['smart_proxy_upgrade.erb'] if plugin.exists? 'foreman_theme_satellite'
Dir["templates/*.erb"].except(unsuppored_templates).each do |template|
  create_template(template)
end

JobTemplate.where(name: unsupported_template).delete_all

[ShimShtein]

Thank you! This looks much cleaner indeed.

[stejskalleos]

🍏 LGTM

Works well for both scenarios (upstream/downstream) and the code looks good too.
@ShimShtein if you don't have any other comments I'm 👍 to merge

[ShimShtein]

LGTM.
I don't really like the fact that we have a piece of code (template in this case) that is not tested either in downstream or upstream, but any other solution would be much more complicated.